mesos-reviews mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From Vinod Kone <vinodk...@gmail.com>
Subject Re: Review Request 58196: Implemented TCP check support in command and default executors.
Date Mon, 17 Apr 2017 17:50:10 GMT


> On April 7, 2017, 1:58 a.m., Vinod Kone wrote:
> > src/checks/checker.cpp
> > Lines 1166-1169 (patched)
> > <https://reviews.apache.org/r/58196/diff/1/?file=1684610#file1684610line1166>
> >
> >     It's a bit unfortunate that the `errno` returned by `connect` is subsumed by
the tcp check command. But I guess there is no easy way to expose that to the scheduler.
> 
> Alexander Rukletsov wrote:
>     I think that the scheduler is not really interested in `errno`. What information
can be interesting for a scheduler, is whether
>     - a check command was configured properly and succeeded to run, but the check result
was `false`,
>     - or there was a problem with the check command itself.
>     
>     We can distinguish these cases in our API by returning `CheckStatusInfo.Tcp` with
absent `succeeded` field. The question is, which errors shall belong to which category. For
example, connection timeouts, or socket creation failures. I'm not too worried about this,
because we can relatively easy adjust later, since the API is already in place.

My suggestion regarding `errno` was basically trying to figure out if we can give more fine
grained information about how a tcp check performed not merely that it succeeded/failed; similar
to how we provide explicit status codes for HTTP check. But, yea we can add that later.


- Vinod


-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/58196/#review171307
-----------------------------------------------------------


On April 7, 2017, 3:25 p.m., Alexander Rukletsov wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/58196/
> -----------------------------------------------------------
> 
> (Updated April 7, 2017, 3:25 p.m.)
> 
> 
> Review request for mesos, Gastón Kleiman and Vinod Kone.
> 
> 
> Bugs: MESOS-7275
>     https://issues.apache.org/jira/browse/MESOS-7275
> 
> 
> Repository: mesos
> 
> 
> Description
> -------
> 
> See summary.
> 
> 
> Diffs
> -----
> 
>   src/checks/checker.hpp fb939d85dbec2bf7e81e0c11518ccecddc5a7a11 
>   src/checks/checker.cpp 7510bf23977e007d101fab635865b7160c3a5af6 
>   src/launcher/default_executor.cpp 9cc40c6391a931f9cdf6965e64be231980537299 
>   src/launcher/executor.cpp d14fbfb65d1cc44c954c8cdbbf36d7ddf6ede19e 
>   src/tests/check_tests.cpp d7fcbf940102efe0841f07e8c4937a78361bc422 
> 
> 
> Diff: https://reviews.apache.org/r/58196/diff/2/
> 
> 
> Testing
> -------
> 
> make check on Mac OS 10.11.6 and various linux variants.
> 
> 
> Thanks,
> 
> Alexander Rukletsov
> 
>


Mime
  • Unnamed multipart/alternative (inline, None, 0 bytes)
View raw message