mesos-reviews mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From Mesos Reviewbot <revi...@mesos.apache.org>
Subject Re: Review Request 58463: Overwriting Symbolic Links with Files in Copy Provisioner.
Date Fri, 14 Apr 2017 23:50:28 GMT

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/58463/#review172042
-----------------------------------------------------------



Patch looks great!

Reviews applied: [58408, 58463]

Passed command: export OS='ubuntu:14.04' BUILDTOOL='autotools' COMPILER='gcc' CONFIGURATION='--verbose'
ENVIRONMENT='GLOG_v=1 MESOS_VERBOSE=1'; ./support/docker-build.sh

- Mesos Reviewbot


On April 14, 2017, 10:04 p.m., Chun-Hung Hsiao wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/58463/
> -----------------------------------------------------------
> 
> (Updated April 14, 2017, 10:04 p.m.)
> 
> 
> Review request for mesos, Gilbert Song, Jie Yu, and Vinod Kone.
> 
> 
> Bugs: MESOS-6327
>     https://issues.apache.org/jira/browse/MESOS-6327
> 
> 
> Repository: mesos
> 
> 
> Description
> -------
> 
> When a layer overwrites a symbolic link with a regular file, the link
> must be removed first, otherwise 'cp' would follow the link and
> overwrite the target instead of the link itself.
> 
> 
> Diffs
> -----
> 
>   src/slave/containerizer/mesos/provisioner/backends/copy.cpp 584cc6524f81cc1bc231b105507dbfe51fec991d

> 
> 
> Diff: https://reviews.apache.org/r/58463/diff/1/
> 
> 
> Testing
> -------
> 
> sudo make check
> 
> Manually tested with the following docker images:
>   https://hub.docker.com/r/anldisr/mesos_layers/ (provided by the reporter)
>   https://hub.docker.com/r/chhsiao/mycrosslink/  (simplist image to reproduce the same
bug)
> 
> 
> Thanks,
> 
> Chun-Hung Hsiao
> 
>


Mime
  • Unnamed multipart/alternative (inline, None, 0 bytes)
View raw message