mesos-reviews mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From Chun-Hung Hsiao <>
Subject Re: Review Request 58463: Overwriting Symbolic Links with Files in Copy Provisioner.
Date Fri, 14 Apr 2017 22:04:15 GMT

This is an automatically generated e-mail. To reply, visit:

(Updated April 14, 2017, 10:04 p.m.)

Review request for mesos, Gilbert Song, Jie Yu, and Vinod Kone.

Bugs: MESOS-6327

Repository: mesos


When a layer overwrites a symbolic link with a regular file, the link
must be removed first, otherwise 'cp' would follow the link and
overwrite the target instead of the link itself.


  src/slave/containerizer/mesos/provisioner/backends/copy.cpp 584cc6524f81cc1bc231b105507dbfe51fec991d


Testing (updated)

sudo make check

Manually tested with the following docker images: (provided by the reporter)  (simplist image to reproduce the same bug)


Chun-Hung Hsiao

  • Unnamed multipart/alternative (inline, None, 0 bytes)
View raw message