mesos-reviews mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From Vinod Kone <vinodk...@gmail.com>
Subject Re: Review Request 58287: Print corresponding address when socket shutdown.
Date Fri, 14 Apr 2017 19:24:38 GMT

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/58287/#review172019
-----------------------------------------------------------




3rdparty/libprocess/src/process.cpp
Line 2361 (original), 2361-2362 (patched)
<https://reviews.apache.org/r/58287/#comment245081>

    Looks like these lines are greater than 80 chars long. Can you wrap them please?
    
    ```
    ?  mesos git:(master) ? ./support/apply-reviews.py -c -r 58287
    2017-04-14 12:23:29 URL:https://reviews.apache.org/r/58287/diff/raw/ [1178/1178] ->
"58287.patch" [1]
    Checking 1 C++ file
    3rdparty/libprocess/src/process.cpp:2361:  Lines should be <= 80 characters long  [whitespace/line_length]
[2]
    3rdparty/libprocess/src/process.cpp:2362:  Lines should be <= 80 characters long  [whitespace/line_length]
[2]
    3rdparty/libprocess/src/process.cpp:2445:  Lines should be <= 80 characters long  [whitespace/line_length]
[2]
    3rdparty/libprocess/src/process.cpp:2446:  Lines should be <= 80 characters long  [whitespace/line_length]
[2]
    Total errors found: 1
    No Python files to lint
    
    ```


- Vinod Kone


On April 13, 2017, 12:44 p.m., Andy Pang wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/58287/
> -----------------------------------------------------------
> 
> (Updated April 13, 2017, 12:44 p.m.)
> 
> 
> Review request for mesos, Jie Yu and Vinod Kone.
> 
> 
> Repository: mesos
> 
> 
> Description
> -------
> 
> Print corresponding address when socket shutdown.
> Default just print socket 'fd',it's not convenient
> to find corresponding address.
> 
> 
> Diffs
> -----
> 
>   3rdparty/libprocess/src/process.cpp 92efa91 
> 
> 
> Diff: https://reviews.apache.org/r/58287/diff/3/
> 
> 
> Testing
> -------
> 
> make check
> 
> 
> File Attachments
> ----------------
> 
> process.patch
>   https://reviews.apache.org/media/uploaded/files/2017/04/13/d5736720-1262-484a-8efd-6e1eeada944d__process.patch
> 
> 
> Thanks,
> 
> Andy Pang
> 
>


Mime
  • Unnamed multipart/alternative (inline, None, 0 bytes)
View raw message