mesos-reviews mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From Greg Mann <g...@mesosphere.io>
Subject Re: Review Request 58328: Updated tests to set '--executor_secret_key' as a path.
Date Thu, 13 Apr 2017 20:14:08 GMT


> On April 13, 2017, 6:54 p.m., Greg Mann wrote:
> > src/tests/mesos.cpp
> > Lines 218-235 (patched)
> > <https://reviews.apache.org/r/58328/diff/1/?file=1687742#file1687742line218>
> >
> >     Use `os::write()`

Looks like we don't provide an overload of `os::write` which accepts access permission bits.


- Greg


-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/58328/#review171915
-----------------------------------------------------------


On April 11, 2017, 4:37 a.m., Greg Mann wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/58328/
> -----------------------------------------------------------
> 
> (Updated April 11, 2017, 4:37 a.m.)
> 
> 
> Review request for mesos, Anand Mazumdar and Vinod Kone.
> 
> 
> Bugs: MESOS-6999
>     https://issues.apache.org/jira/browse/MESOS-6999
> 
> 
> Repository: mesos
> 
> 
> Description
> -------
> 
> This patch updates the test code to generate a secret key file
> and set the agent '--executor_secret_key' flag with its path.
> 
> 
> Diffs
> -----
> 
>   src/tests/mesos.cpp 099ec376878faaa7efe5bc030785db717cb16f59 
> 
> 
> Diff: https://reviews.apache.org/r/58328/diff/1/
> 
> 
> Testing
> -------
> 
> `make check`
> 
> 
> Thanks,
> 
> Greg Mann
> 
>


Mime
  • Unnamed multipart/alternative (inline, None, 0 bytes)
View raw message