mesos-reviews mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From Greg Mann <g...@mesosphere.io>
Subject Re: Review Request 58327: Changed '--executor_secret_key' agent flag to accept a path.
Date Thu, 13 Apr 2017 18:52:00 GMT

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/58327/#review171913
-----------------------------------------------------------




src/slave/slave.cpp
Lines 307-312 (patched)
<https://reviews.apache.org/r/58327/#comment244907>

    Add TODO to factor this out.


- Greg Mann


On April 13, 2017, 6:48 p.m., Greg Mann wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/58327/
> -----------------------------------------------------------
> 
> (Updated April 13, 2017, 6:48 p.m.)
> 
> 
> Review request for mesos, Anand Mazumdar and Vinod Kone.
> 
> 
> Bugs: MESOS-6999
>     https://issues.apache.org/jira/browse/MESOS-6999
> 
> 
> Repository: mesos
> 
> 
> Description
> -------
> 
> This patch changes the agent flag '--executor_secret_key' to accept
> a path, so that the secret will not be leaked in logs.
> 
> 
> Diffs
> -----
> 
>   docs/configuration.md 452478eab36f352a31f62f0c1f4da2f43f89bef9 
>   src/slave/flags.hpp 171f67e44518e858049d002fcf037715021da265 
>   src/slave/flags.cpp 9365da2c8462a4375a99a86210b9d6ec628510fe 
>   src/slave/slave.cpp f013e9c7d1c089ec72e2e5db986fd52423ebb8fe 
> 
> 
> Diff: https://reviews.apache.org/r/58327/diff/2/
> 
> 
> Testing
> -------
> 
> Testing details are found in the following patch in this chain.
> 
> 
> Thanks,
> 
> Greg Mann
> 
>


Mime
  • Unnamed multipart/alternative (inline, None, 0 bytes)
View raw message