mesos-reviews mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From John Kordich via Review Board <nore...@reviews.apache.org>
Subject Re: Review Request 58430: Changed some failing Base64 tests to use 'u8' string literals.
Date Thu, 13 Apr 2017 18:48:22 GMT

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/58430/
-----------------------------------------------------------

(Updated April 13, 2017, 6:48 p.m.)


Review request for mesos, Andrew Schwartzmeyer and Joseph Wu.


Changes
-------

These changes will fix the unit test failures on Windows by making sure that the string literals
are encoded into bytes identically across platforms.


Bugs: MESOS-7236
    https://issues.apache.org/jira/browse/MESOS-7236


Repository: mesos


Description
-------

Changed some failing Base64 tests to use 'u8' string literals.


Diffs
-----

  3rdparty/stout/tests/base64_tests.cpp 0473221abb352195e03ae970709eadcfc44d77b0 


Diff: https://reviews.apache.org/r/58430/diff/1/


Testing
-------

Ran make check on Linux and ran stout-tests on Windows.


Thanks,

John Kordich


Mime
  • Unnamed multipart/alternative (inline, None, 0 bytes)
View raw message