mesos-reviews mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From Vinod Kone <vinodk...@gmail.com>
Subject Re: Review Request 58263: Inherited working dir from parent when launching a DEBUG container.
Date Thu, 13 Apr 2017 00:47:55 GMT

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/58263/#review171830
-----------------------------------------------------------




src/slave/containerizer/mesos/containerizer.hpp
Lines 325 (patched)
<https://reviews.apache.org/r/58263/#comment244848>

    Can you elaborate how it is different?



src/slave/containerizer/mesos/containerizer.cpp
Lines 1492 (patched)
<https://reviews.apache.org/r/58263/#comment244849>

    don't you need to checkpoint/recover this?


- Vinod Kone


On April 7, 2017, 4:19 p.m., Alexander Rukletsov wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/58263/
> -----------------------------------------------------------
> 
> (Updated April 7, 2017, 4:19 p.m.)
> 
> 
> Review request for mesos, Gastón Kleiman, Jie Yu, Kevin Klues, and Vinod Kone.
> 
> 
> Repository: mesos
> 
> 
> Description
> -------
> 
> See summary.
> 
> 
> Diffs
> -----
> 
>   src/slave/containerizer/mesos/containerizer.hpp 29a99f33e646593127b9dc126f398f7bca88e21d

>   src/slave/containerizer/mesos/containerizer.cpp bc611a5e085de10e9953b5f942d98f2b5747fce6

> 
> 
> Diff: https://reviews.apache.org/r/58263/diff/2/
> 
> 
> Testing
> -------
> 
> make check on Mac OS.
> Linux pending.
> 
> 
> Thanks,
> 
> Alexander Rukletsov
> 
>


Mime
  • Unnamed multipart/alternative (inline, None, 0 bytes)
View raw message