mesos-reviews mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From Jie Yu <yujie....@gmail.com>
Subject Re: Review Request 58329: Parameterized the existing alpine based test with more registries.
Date Wed, 12 Apr 2017 21:20:35 GMT

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/58329/#review171797
-----------------------------------------------------------


Fix it, then Ship it!





src/tests/containerizer/provisioner_docker_tests.cpp
Lines 457-459 (patched)
<https://reviews.apache.org/r/58329/#comment244799>

    I would add "library/alpine" here as well



src/tests/containerizer/provisioner_docker_tests.cpp
Line 531 (original), 542 (patched)
<https://reviews.apache.org/r/58329/#comment244796>

    hum, looks like this test is not necessary. Can you remove it in a followup patch?


- Jie Yu


On April 11, 2017, 7:17 p.m., Gilbert Song wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/58329/
> -----------------------------------------------------------
> 
> (Updated April 11, 2017, 7:17 p.m.)
> 
> 
> Review request for mesos, Avinash sridharan, Chun-Hung Hsiao, Artem Harutyunyan, Ilya
Pronin, Jie Yu, Timothy Chen, and Vinod Kone.
> 
> 
> Bugs: MESOS-5172
>     https://issues.apache.org/jira/browse/MESOS-5172
> 
> 
> Repository: mesos
> 
> 
> Description
> -------
> 
> Now we test alpine image from three registries:
> 1. docker hub.
> 2. quay.io.
> 3. alicloud.
> 
> 
> Diffs
> -----
> 
>   src/tests/containerizer/provisioner_docker_tests.cpp dbbc3533ae269c31c98017d98888d5748ef6e1ce

> 
> 
> Diff: https://reviews.apache.org/r/58329/diff/1/
> 
> 
> Testing
> -------
> 
> make check
> 
> 
> Thanks,
> 
> Gilbert Song
> 
>


Mime
  • Unnamed multipart/alternative (inline, None, 0 bytes)
View raw message