mesos-reviews mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From Jie Yu <yujie....@gmail.com>
Subject Re: Review Request 48917: Fixed docker fetcher 3xx redirect errors by header attached.
Date Wed, 12 Apr 2017 21:09:19 GMT

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/48917/#review171789
-----------------------------------------------------------


Fix it, then Ship it!





src/uri/fetchers/docker.cpp
Lines 280 (patched)
<https://reviews.apache.org/r/48917/#comment244791>

    I would add more info to the error message here:
    ```
    return Failure("Unexpected 'curl' output: " + output.get());
    ```



src/uri/fetchers/docker.cpp
Line 284 (original), 285 (patched)
<https://reviews.apache.org/r/48917/#comment244792>

    Unexpected HTTP response code from 'curl'


- Jie Yu


On April 11, 2017, 7:17 p.m., Gilbert Song wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/48917/
> -----------------------------------------------------------
> 
> (Updated April 11, 2017, 7:17 p.m.)
> 
> 
> Review request for mesos, Avinash sridharan, Chun-Hung Hsiao, Artem Harutyunyan, Ilya
Pronin, Jie Yu, Timothy Chen, and Vinod Kone.
> 
> 
> Bugs: MESOS-5172
>     https://issues.apache.org/jira/browse/MESOS-5172
> 
> 
> Repository: mesos
> 
> 
> Description
> -------
> 
> The root cause for this issue is that, in private registry
> like quay.io, layer download request will be redirected to
> storage server in S3. However, the curl command with '-L'
> handles HTTP redirection automatically, in which case HTTP
> headers will be attached to all requests. AmazonS3 server
> will return 400 Bad Request if HTTP Authorization header
> is attached, with 'InvalidArgument' error code. So we need
> to touch the given URL first to add extra logic for HTTP
> redirections.
> 
> Please note that the download() method is changed to be
> recursive since no header should be attached once the
> request get authenticated.
> 
> 
> Diffs
> -----
> 
>   src/uri/fetchers/docker.cpp d6d2e8e72554c5f96c3875af8ef93e0bc2107af6 
> 
> 
> Diff: https://reviews.apache.org/r/48917/diff/3/
> 
> 
> Testing
> -------
> 
> make check
> 
> Tested with quay.io/gilbertsong/inky manually.
> 
> 
> Thanks,
> 
> Gilbert Song
> 
>


Mime
  • Unnamed multipart/alternative (inline, None, 0 bytes)
View raw message