mesos-reviews mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From Armand Grillet <agril...@mesosphere.io>
Subject Re: Review Request 57951: Moved new CLI settings into a user-defined TOML file.
Date Wed, 12 Apr 2017 19:59:33 GMT

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/57951/
-----------------------------------------------------------

(Updated April 12, 2017, 7:59 p.m.)


Review request for mesos, Joseph Wu and Kevin Klues.


Changes
-------

Rebased.


Bugs: MESOS-7269
    https://issues.apache.org/jira/browse/MESOS-7269


Repository: mesos


Description (updated)
-------

These settings were previously in settings.py.
We now use a TOML file containing the configuration, this
format has been chosen because:
  * It supports comments.
  * It is well-specified.
  * It allows logical grouping.
  * It maps ubiquitous data types.
The config file environment variable, previously
`MESOS_CLI_CONFIG_PATH`, is now `MESOS_CLI_CONFIG`. This
change follows the design doc about the new CLI.
This environement variable `MESOS_CLI_PLUGINS` is not used
anymore as plugins can be added using the TOML file instead.


Diffs (updated)
-----

  src/cli_new/README.md aa118132688253d3cec0b27fd6b394f5bc2bdd94 
  src/cli_new/bin/settings.py 2f6162edc1722054bc44ad25956e6fe666d36c7f 
  src/cli_new/pip-requirements.txt e73bbfde98f28693463a46b166197ad1fd53c0cb 


Diff: https://reviews.apache.org/r/57951/diff/6/

Changes: https://reviews.apache.org/r/57951/diff/5-6/


Testing
-------

Tested manually, PEP8 and Pylint used to make sure that the code style is correct.


Thanks,

Armand Grillet


Mime
  • Unnamed multipart/alternative (inline, None, 0 bytes)
View raw message