mesos-reviews mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From Jie Yu <yujie....@gmail.com>
Subject Re: Review Request 58287: Print corresponding address when socket shutdown.
Date Wed, 12 Apr 2017 18:39:14 GMT

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/58287/#review171772
-----------------------------------------------------------




3rdparty/libprocess/src/process.cpp
Lines 2362 (patched)
<https://reviews.apache.org/r/58287/#comment244776>

    What if socket.address returns an Error? Let's not print the address if it is an error:
    
    ```
    Try<network::Address> socketAddress = socket.address();
    
    LOG(ERROR) << "Failed to shutdown socket with fd " << socket.get() <<
", address "
               << (socketAddress.isSome() ? stringify(socketAddress.get()) : "N/A")
               << ": " << shutdown.error();
    ```



3rdparty/libprocess/src/process.cpp
Lines 2446 (patched)
<https://reviews.apache.org/r/58287/#comment244777>

    Ditto.


- Jie Yu


On April 12, 2017, 1:42 a.m., Andy Pang wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/58287/
> -----------------------------------------------------------
> 
> (Updated April 12, 2017, 1:42 a.m.)
> 
> 
> Review request for mesos, Jie Yu and Vinod Kone.
> 
> 
> Repository: mesos
> 
> 
> Description
> -------
> 
> Print corresponding address when socket shutdown.
> Default just print socket 'fd',it's not convenient
> to find corresponding address.
> 
> 
> Diffs
> -----
> 
>   3rdparty/libprocess/src/process.cpp 92efa91 
> 
> 
> Diff: https://reviews.apache.org/r/58287/diff/2/
> 
> 
> Testing
> -------
> 
> make check
> 
> 
> Thanks,
> 
> Andy Pang
> 
>


Mime
  • Unnamed multipart/alternative (inline, None, 0 bytes)
View raw message