mesos-reviews mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From Mesos Reviewbot <revi...@mesos.apache.org>
Subject Re: Review Request 57951: Moved new CLI settings into a user-defined TOML file.
Date Wed, 12 Apr 2017 17:02:44 GMT

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/57951/#review171756
-----------------------------------------------------------



Bad patch!

Reviews applied: [57951, 57896]

Failed command: python support/apply-reviews.py -n -r 57951

Error:
2017-04-12 17:02:43 URL:https://reviews.apache.org/r/57951/diff/raw/ [4329/4329] -> "57951.patch"
[1]
error: patch failed: src/cli_new/README.md:34
error: src/cli_new/README.md: patch does not apply
error: patch failed: src/cli_new/pip-requirements.txt:9
error: src/cli_new/pip-requirements.txt: patch does not apply

Full log: https://builds.apache.org/job/Mesos-Reviewbot/17741/console

- Mesos Reviewbot


On April 12, 2017, 9:07 a.m., Armand Grillet wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/57951/
> -----------------------------------------------------------
> 
> (Updated April 12, 2017, 9:07 a.m.)
> 
> 
> Review request for mesos, Joseph Wu and Kevin Klues.
> 
> 
> Bugs: MESOS-7269
>     https://issues.apache.org/jira/browse/MESOS-7269
> 
> 
> Repository: mesos
> 
> 
> Description
> -------
> 
> These settings were previously in settings.py.
> We now use a TOML file containing the configuration, this
> format has been chosen because:
>   * It supports comments.
>   * It is well-specified.
>   * It allows logical grouping.
>   * It maps ubiquitous data types.
> The config file environment variable, previously
> `MESOS_CLI_CONFIG_PATH`, is now `MESOS_CLI_CONFIG`. This
> change follows the design doc about the new CLI.
> The environement variable `MESOS_CLI_PLUGINS` is not used
> anymore as plugins can be added using the TOML file instead.
> 
> 
> Diffs
> -----
> 
>   src/cli_new/README.md 0e60515b71192ce1a544711948a5c17a6f9002af 
>   src/cli_new/bin/settings.py 2f6162edc1722054bc44ad25956e6fe666d36c7f 
>   src/cli_new/pip-requirements.txt 9cc8d096ac353f4ed2d40000318f2d0e439a6edf 
> 
> 
> Diff: https://reviews.apache.org/r/57951/diff/5/
> 
> 
> Testing
> -------
> 
> Tested manually, PEP8 and Pylint used to make sure that the code style is correct.
> 
> 
> Thanks,
> 
> Armand Grillet
> 
>


Mime
  • Unnamed multipart/alternative (inline, None, 0 bytes)
View raw message