mesos-reviews mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From Alexander Rukletsov <ruklet...@gmail.com>
Subject Re: Review Request 58369: Updated default executor to pass authorization header to checkers.
Date Wed, 12 Apr 2017 09:53:13 GMT

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/58369/#review171700
-----------------------------------------------------------




src/launcher/default_executor.cpp
Line 138 (original), 138-140 (patched)
<https://reviews.apache.org/r/58369/#comment244738>

    I know this have been here before, but it looks like a magic constant. "Bearer" seems
like just one of the possible schemes: https://www.iana.org/assignments/http-authschemes/http-authschemes.xhtml
    
    It would be great to assemble the resulting value `"Bearer <token>"` in a single
place.



src/launcher/default_executor.cpp
Line 1299 (original), 1303 (patched)
<https://reviews.apache.org/r/58369/#comment244739>

    Technically, this rename is not part of the patch descirption. I would have had this in
a separate patch, but I leave this up to you and your shepherd.


- Alexander Rukletsov


On April 12, 2017, 9:21 a.m., Greg Mann wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/58369/
> -----------------------------------------------------------
> 
> (Updated April 12, 2017, 9:21 a.m.)
> 
> 
> Review request for mesos, Alexander Rukletsov, Anand Mazumdar, Gastón Kleiman, and Vinod
Kone.
> 
> 
> Bugs: MESOS-7377
>     https://issues.apache.org/jira/browse/MESOS-7377
> 
> 
> Repository: mesos
> 
> 
> Description
> -------
> 
> This patch updates the default executor to pass the executor's
> authorization header to the `Checker` and `HealthChecker`
> libraries when an authentication token is present in the
> environment.
> 
> 
> Diffs
> -----
> 
>   src/launcher/default_executor.cpp 9cc40c6391a931f9cdf6965e64be231980537299 
> 
> 
> Diff: https://reviews.apache.org/r/58369/diff/1/
> 
> 
> Testing
> -------
> 
> Testing details can be found at the end of this chain.
> 
> 
> Thanks,
> 
> Greg Mann
> 
>


Mime
  • Unnamed multipart/alternative (inline, None, 0 bytes)
View raw message