mesos-reviews mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From Jay Guo <guojiannan1...@gmail.com>
Subject Re: Review Request 58095: Refactored functions that render /roles and GetRoles endpoints.
Date Wed, 12 Apr 2017 05:37:18 GMT


> On April 7, 2017, 9:11 p.m., Alexander Rojas wrote:
> > src/master/http.cpp
> > Line 3383 (original), 3385 (patched)
> > <https://reviews.apache.org/r/58095/diff/2/?file=1684472#file1684472line3385>
> >
> >     With the proposed changes, there's no reason to have this function in `Master::Http`
and can be move directly to `Master` IMHO.
> >     
> >     Probably the name can be change to `activeRoles` too, since it makes more sense
given the description of _interesting roles_.

Thanks for your review. I changed method name to be more expressive. However, this method
is only used by `Master::Http` and not intended for `Master`, I feel we should let it stay
in `Master::Http`. What do you think.


- Jay


-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/58095/#review171337
-----------------------------------------------------------


On April 12, 2017, 1:35 p.m., Jay Guo wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/58095/
> -----------------------------------------------------------
> 
> (Updated April 12, 2017, 1:35 p.m.)
> 
> 
> Review request for mesos, Adam B, Alexander Rojas, Benjamin Mahler, and Michael Park.
> 
> 
> Bugs: MESOS-4732 and MESOS-7260
>     https://issues.apache.org/jira/browse/MESOS-4732
>     https://issues.apache.org/jira/browse/MESOS-7260
> 
> 
> Repository: mesos
> 
> 
> Description
> -------
> 
> Instead of generating JSON object, `Master::Http::roles()` now
> leverages `jsonify` to compute output. Also approver is taken
> out from its continuation function. This is for easier and cleaner
> implementation of framework authorization in /roles endpoint,
> see MESOS-7260.
> 
> 
> Diffs
> -----
> 
>   src/master/http.cpp 0e84d363b346de1ef05101dac066c2f0cf31609d 
>   src/master/master.hpp d537933d0b467a6f9996951c601b31338bb9d034 
> 
> 
> Diff: https://reviews.apache.org/r/58095/diff/3/
> 
> 
> Testing
> -------
> 
> no functional changes
> make check
> 
> 
> Thanks,
> 
> Jay Guo
> 
>


Mime
  • Unnamed multipart/alternative (inline, None, 0 bytes)
View raw message