mesos-reviews mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From Jay Guo <guojiannan1...@gmail.com>
Subject Re: Review Request 58095: Refactored functions that render /roles and GetRoles endpoints.
Date Wed, 12 Apr 2017 05:35:14 GMT

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/58095/
-----------------------------------------------------------

(Updated April 12, 2017, 1:35 p.m.)


Review request for mesos, Adam B, Alexander Rojas, Benjamin Mahler, and Michael Park.


Changes
-------

tweak indentation and method name to address arojas's comments.


Bugs: MESOS-4732 and MESOS-7260
    https://issues.apache.org/jira/browse/MESOS-4732
    https://issues.apache.org/jira/browse/MESOS-7260


Repository: mesos


Description
-------

Instead of generating JSON object, `Master::Http::roles()` now
leverages `jsonify` to compute output. Also approver is taken
out from its continuation function. This is for easier and cleaner
implementation of framework authorization in /roles endpoint,
see MESOS-7260.


Diffs (updated)
-----

  src/master/http.cpp 0e84d363b346de1ef05101dac066c2f0cf31609d 
  src/master/master.hpp d537933d0b467a6f9996951c601b31338bb9d034 


Diff: https://reviews.apache.org/r/58095/diff/3/

Changes: https://reviews.apache.org/r/58095/diff/2-3/


Testing
-------

no functional changes
make check


Thanks,

Jay Guo


Mime
  • Unnamed multipart/alternative (inline, None, 0 bytes)
View raw message