mesos-reviews mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From Joseph Wu <jos...@mesosphere.io>
Subject Re: Review Request 58146: Added infrastructure for unit tests in the new python-based CLI.
Date Tue, 11 Apr 2017 23:22:08 GMT

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/58146/#review171655
-----------------------------------------------------------


Ship it!




LGTM.

- Joseph Wu


On April 9, 2017, 11:40 p.m., Armand Grillet wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/58146/
> -----------------------------------------------------------
> 
> (Updated April 9, 2017, 11:40 p.m.)
> 
> 
> Review request for mesos, Joseph Wu and Kevin Klues.
> 
> 
> Bugs: MESOS-6032
>     https://issues.apache.org/jira/browse/MESOS-6032
> 
> 
> Repository: mesos
> 
> 
> Description
> -------
> 
> This is the base to develop unit tests for the Mesos CLI.
> 
> 
> Diffs
> -----
> 
>   src/cli_new/README.md 0e60515b71192ce1a544711948a5c17a6f9002af 
>   src/cli_new/bin/mesos-cli-tests PRE-CREATION 
>   src/cli_new/pip-requirements.txt 9cc8d096ac353f4ed2d40000318f2d0e439a6edf 
>   src/cli_new/tests/main.py PRE-CREATION 
> 
> 
> Diff: https://reviews.apache.org/r/58146/diff/1/
> 
> 
> Testing
> -------
> 
> $ cd src/cli_new
> $ ./bootstrap
> $ source activate
> 
> (mesos-cli) $ mesos-cli-tests
> 
> 
> Thanks,
> 
> Armand Grillet
> 
>


Mime
  • Unnamed multipart/alternative (inline, None, 0 bytes)
View raw message