mesos-reviews mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From Joseph Wu <jos...@mesosphere.io>
Subject Re: Review Request 57952: Added 'config' plugin to the new CLI.
Date Tue, 11 Apr 2017 22:45:39 GMT

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/57952/#review171650
-----------------------------------------------------------




src/cli_new/lib/cli/plugins/config/main.py
Lines 54-62 (patched)
<https://reviews.apache.org/r/57952/#comment244639>

    Not sure if this `silent` field is really necessary.  It doesn't appear to be configurable
(rather, you basically ignore the field in the plugin's methods)...



src/cli_new/lib/cli/util.py
Lines 155 (patched)
<https://reviews.apache.org/r/57952/#comment244641>

    I'd like to the Table added in a separate commit, as it will probably be used in multiple
plugins, in future.



src/cli_new/lib/cli/util.py
Lines 190 (patched)
<https://reviews.apache.org/r/57952/#comment244636>

    s/no/not/



src/cli_new/lib/cli/util.py
Lines 192 (patched)
<https://reviews.apache.org/r/57952/#comment244638>

    Period at the end...


- Joseph Wu


On April 11, 2017, 7:52 a.m., Armand Grillet wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/57952/
> -----------------------------------------------------------
> 
> (Updated April 11, 2017, 7:52 a.m.)
> 
> 
> Review request for mesos, Joseph Wu and Kevin Klues.
> 
> 
> Bugs: MESOS-7269
>     https://issues.apache.org/jira/browse/MESOS-7269
> 
> 
> Repository: mesos
> 
> 
> Description
> -------
> 
> Used to show the plugins available for the user.
> A Table abstraction has been added to print the plugins.
> 
> 
> Diffs
> -----
> 
>   src/cli_new/bin/settings.py 2f6162edc1722054bc44ad25956e6fe666d36c7f 
>   src/cli_new/lib/cli/plugins/config/__init__.py PRE-CREATION 
>   src/cli_new/lib/cli/plugins/config/main.py PRE-CREATION 
>   src/cli_new/lib/cli/util.py ace07fb64e130e2f02d4ab5607ee1a84161ef88b 
> 
> 
> Diff: https://reviews.apache.org/r/57952/diff/4/
> 
> 
> Testing
> -------
> 
> Tested manually, PEP8 and Pylint used to make sure that the code style is correct.
> 
> 
> Thanks,
> 
> Armand Grillet
> 
>


Mime
  • Unnamed multipart/alternative (inline, None, 0 bytes)
View raw message