mesos-reviews mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From Joseph Wu <jos...@mesosphere.io>
Subject Re: Review Request 57971: Added test filtering framework to libprocess-tests.
Date Tue, 11 Apr 2017 21:33:32 GMT

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/57971/#review171619
-----------------------------------------------------------




3rdparty/libprocess/src/tests/main.cpp
Lines 34 (patched)
<https://reviews.apache.org/r/57971/#comment244575>

    Made a comment about a similar looking line in the previous review.  Same comment here.
    https://reviews.apache.org/r/57824/#comment244563


- Joseph Wu


On April 10, 2017, 2:41 p.m., John Kordich wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/57971/
> -----------------------------------------------------------
> 
> (Updated April 10, 2017, 2:41 p.m.)
> 
> 
> Review request for mesos, Andrew Schwartzmeyer and Joseph Wu.
> 
> 
> Bugs: MESOS-6731
>     https://issues.apache.org/jira/browse/MESOS-6731
> 
> 
> Repository: mesos
> 
> 
> Description
> -------
> 
> Added test filtering framework to libprocess-tests.
> 
> 
> Diffs
> -----
> 
>   3rdparty/libprocess/src/tests/main.cpp cda7d61e1f10fde8a457c6077d4eb7aa78b390fc 
> 
> 
> Diff: https://reviews.apache.org/r/57971/diff/3/
> 
> 
> Testing
> -------
> 
> Ran make check on Linux and the tests on Windows.
> 
> 
> Thanks,
> 
> John Kordich
> 
>


Mime
  • Unnamed multipart/alternative (inline, None, 0 bytes)
View raw message