mesos-reviews mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From Vinod Kone <vinodk...@gmail.com>
Subject Re: Review Request 57816: Add a scheduler flag `offers_suppressed_on_register`.
Date Tue, 11 Apr 2017 20:25:11 GMT

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/57816/#review171628
-----------------------------------------------------------




src/sched/flags.hpp
Lines 127 (patched)
<https://reviews.apache.org/r/57816/#comment244590>

    i would name it "suppress_offers_on_registration"



src/sched/sched.cpp
Lines 826 (patched)
<https://reviews.apache.org/r/57816/#comment244591>

    s/offersSuppressed/suppressOffers/


- Vinod Kone


On April 3, 2017, 10:34 p.m., Anindya Sinha wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/57816/
> -----------------------------------------------------------
> 
> (Updated April 3, 2017, 10:34 p.m.)
> 
> 
> Review request for mesos, James Peach, Vinod Kone, and Jiang Yan Xu.
> 
> 
> Bugs: MESOS-7015
>     https://issues.apache.org/jira/browse/MESOS-7015
> 
> 
> Repository: mesos
> 
> 
> Description
> -------
> 
> If the framework sets this flag to indicate that it wants offers
> suppressed on successful registration to master, we pass this
> information to the master in the `SUBSCRIBE` call.
> 
> 
> Diffs
> -----
> 
>   src/sched/flags.hpp d19d20bad7dba48c8792783c73115affa1430cbe 
>   src/sched/sched.cpp ef73c1dccfd736b79f40a057951f022df7f60644 
> 
> 
> Diff: https://reviews.apache.org/r/57816/diff/2/
> 
> 
> Testing
> -------
> 
> All tests passed.
> 
> 
> Thanks,
> 
> Anindya Sinha
> 
>


Mime
  • Unnamed multipart/alternative (inline, None, 0 bytes)
View raw message