mesos-reviews mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From Vinod Kone <vinodk...@gmail.com>
Subject Re: Review Request 57815: Added `offers_suppressed` field in SUBSCRIBE.
Date Tue, 11 Apr 2017 19:38:14 GMT

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/57815/#review171623
-----------------------------------------------------------




include/mesos/scheduler/scheduler.proto
Lines 251 (patched)
<https://reviews.apache.org/r/57815/#comment244584>

    Can we use an active word here, say "suppress_offers" or "suppress", because our calls
use active verbs? The way I see it, this is just a way of sending SUBSCRIBE and SUPRESS calls
atomically.


- Vinod Kone


On March 31, 2017, 8:20 p.m., Anindya Sinha wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/57815/
> -----------------------------------------------------------
> 
> (Updated March 31, 2017, 8:20 p.m.)
> 
> 
> Review request for mesos, James Peach, Vinod Kone, and Jiang Yan Xu.
> 
> 
> Bugs: MESOS-7015
>     https://issues.apache.org/jira/browse/MESOS-7015
> 
> 
> Repository: mesos
> 
> 
> Description
> -------
> 
> If set, offers are suppressed on registration for this framework.
> Defaults to false.
> 
> 
> Diffs
> -----
> 
>   include/mesos/scheduler/scheduler.proto cee0a175fcdcbb8b56d41a5b4b6fd965afd822bd 
>   include/mesos/v1/scheduler/scheduler.proto 00a54eceb435de8e8fea3ccab285f39ed13c6fee

> 
> 
> Diff: https://reviews.apache.org/r/57815/diff/1/
> 
> 
> Testing
> -------
> 
> All tests passed.
> 
> 
> Thanks,
> 
> Anindya Sinha
> 
>


Mime
  • Unnamed multipart/alternative (inline, None, 0 bytes)
View raw message