mesos-reviews mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From Vinod Kone <vinodk...@gmail.com>
Subject Re: Review Request 58320: Added an upgrade test for executor authentication.
Date Tue, 11 Apr 2017 19:18:08 GMT

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/58320/#review171618
-----------------------------------------------------------


Fix it, then Ship it!




Nice test!


src/tests/slave_tests.cpp
Lines 6041-6042 (patched)
<https://reviews.apache.org/r/58320/#comment244572>

    why is one a ref and not the other?


- Vinod Kone


On April 11, 2017, 4:46 a.m., Greg Mann wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/58320/
> -----------------------------------------------------------
> 
> (Updated April 11, 2017, 4:46 a.m.)
> 
> 
> Review request for mesos, Anand Mazumdar and Vinod Kone.
> 
> 
> Bugs: MESOS-6999
>     https://issues.apache.org/jira/browse/MESOS-6999
> 
> 
> Repository: mesos
> 
> 
> Description
> -------
> 
> This patch adds a new test,
> `SlaveTest.RestartSlaveRequireExecutorAuthentication`, which
> ensures that an executor which is launched with the
> '--executor_secret_key' flag set but the
> '--authenticate_http_executors' flag not set will be able to
> subscribe successfully after the agent is restarted with the
> '--authenticate_http_executors' flag set.
> 
> 
> Diffs
> -----
> 
>   src/tests/slave_tests.cpp 7cb2570920baadf45edc4e8227e1fbbf59cb03d2 
> 
> 
> Diff: https://reviews.apache.org/r/58320/diff/2/
> 
> 
> Testing
> -------
> 
> `bin/mesos-tests.sh --gtest_filter="SlaveTest.RestartSlaveRequireExecutorAuthentication"
--gtest_repeat=-1 --gtest_break_on_failure`
> 
> 
> Thanks,
> 
> Greg Mann
> 
>


Mime
  • Unnamed multipart/alternative (inline, None, 0 bytes)
View raw message