mesos-reviews mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From Vinod Kone <vinodk...@gmail.com>
Subject Re: Review Request 58258: Added a new agent authorization test which runs a task group.
Date Tue, 11 Apr 2017 19:06:01 GMT

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/58258/#review171610
-----------------------------------------------------------




src/tests/slave_authorization_tests.cpp
Lines 499-506 (patched)
<https://reviews.apache.org/r/58258/#comment244555>

    Why do you need to test the `run_tasks` ACL in this test?



src/tests/slave_authorization_tests.cpp
Lines 566 (patched)
<https://reviews.apache.org/r/58258/#comment244553>

    why do you need to configure this?



src/tests/slave_authorization_tests.cpp
Lines 566 (patched)
<https://reviews.apache.org/r/58258/#comment244554>

    why do you need to configure this?


- Vinod Kone


On April 7, 2017, 3:46 a.m., Greg Mann wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/58258/
> -----------------------------------------------------------
> 
> (Updated April 7, 2017, 3:46 a.m.)
> 
> 
> Review request for mesos, Adam B, Alexander Rojas, Till Toenshoff, and Vinod Kone.
> 
> 
> Bugs: MESOS-7339
>     https://issues.apache.org/jira/browse/MESOS-7339
> 
> 
> Repository: mesos
> 
> 
> Description
> -------
> 
> This patch adds a new test,
> `SlaveAuthorizerTest.AuthorizeRunTaskGroupOnAgent`,
> which verifies that task groups can be launched when
> executor authentication is required and the local
> authorizer is loaded.
> 
> 
> Diffs
> -----
> 
>   src/tests/slave_authorization_tests.cpp 3657e0a3d19d75cef92e5bf90b65ef00c291b032 
> 
> 
> Diff: https://reviews.apache.org/r/58258/diff/1/
> 
> 
> Testing
> -------
> 
> `make check` when configured with SSL enabled.
> 
> 
> Thanks,
> 
> Greg Mann
> 
>


Mime
  • Unnamed multipart/alternative (inline, None, 0 bytes)
View raw message