mesos-reviews mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From Mesos Reviewbot <revi...@mesos.apache.org>
Subject Re: Review Request 58351: Updated GMock/GTest in libprocess.
Date Tue, 11 Apr 2017 18:59:28 GMT

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/58351/#review171609
-----------------------------------------------------------



Bad patch!

Reviews applied: [58351, 58350, 58349, 58348, 58347]

Failed command: python support/apply-reviews.py -n -r 58349

Error:
2017-04-11 18:59:27 URL:https://reviews.apache.org/r/58349/diff/raw/ [13902/13902] -> "58349.patch"
[1]
error: missing binary patch data for '3rdparty/googletest-release-1.8.0.tar.gz'
error: binary patch does not apply to '3rdparty/googletest-release-1.8.0.tar.gz'
error: 3rdparty/googletest-release-1.8.0.tar.gz: patch does not apply

Full log: https://builds.apache.org/job/Mesos-Reviewbot/17724/console

- Mesos Reviewbot


On April 11, 2017, 12:31 p.m., Jan Schlicht wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/58351/
> -----------------------------------------------------------
> 
> (Updated April 11, 2017, 12:31 p.m.)
> 
> 
> Review request for mesos, Neil Conway and Till Toenshoff.
> 
> 
> Bugs: MESOS-7364
>     https://issues.apache.org/jira/browse/MESOS-7364
> 
> 
> Repository: mesos
> 
> 
> Description
> -------
> 
> This will fix various issues that occured with version 1.7.0.
> As GTest is now using 'std::tuple' instead of 'std::tr1::tuple', some
> test cases have been updated accordingly.
> 
> 
> Diffs
> -----
> 
>   3rdparty/libprocess/3rdparty/Makefile.am 9dc5fb51d8120d0b26b3f158f69191e468694275 
>   3rdparty/libprocess/Makefile.am 80758d60cd2b391105c30151883c3c7dbf763a31 
>   3rdparty/libprocess/cmake/ProcessTestsConfigure.cmake 31e20e475a4f51ea74eeebae2a026264589e8dda

>   3rdparty/libprocess/configure.ac 1540006e6189cf6618d7f1df4d4b9544bd1c25ea 
>   3rdparty/libprocess/include/process/gmock.hpp 05d8b8e55ab3aa526adb0f7df4683cbd535926f8

> 
> 
> Diff: https://reviews.apache.org/r/58351/diff/1/
> 
> 
> Testing
> -------
> 
> make check (on macOS, Linux, Windows)
> 
> 
> Thanks,
> 
> Jan Schlicht
> 
>


Mime
  • Unnamed multipart/alternative (inline, None, 0 bytes)
View raw message