mesos-reviews mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From James Peach <jpe...@apache.org>
Subject Re: Review Request 58304: Remove unnecessary hashmap lookups.
Date Tue, 11 Apr 2017 16:27:46 GMT

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/58304/
-----------------------------------------------------------

(Updated April 11, 2017, 4:27 p.m.)


Review request for mesos and Mesos Reviewbot.


Changes
-------

Rebased and addresses review feedback.


Bugs: MESOS-7372
    https://issues.apache.org/jira/browse/MESOS-7372


Repository: mesos


Description
-------

In a number of places, we tested whether the slaves hashmap contains
the desired element before indexing it. It is safe to just index it and
check for a NULL result, which saves us some hashing and lookups.


Diffs (updated)
-----

  src/master/master.cpp c1f3c4f3bbcbfb10ae8fc974bd4a16ec070a79fd 


Diff: https://reviews.apache.org/r/58304/diff/2/

Changes: https://reviews.apache.org/r/58304/diff/1-2/


Testing
-------

Make check (Fedora 25). Internal fuzzing.


Thanks,

James Peach


Mime
  • Unnamed multipart/alternative (inline, None, 0 bytes)
View raw message