mesos-reviews mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From Armand Grillet <agril...@mesosphere.io>
Subject Re: Review Request 57952: Added 'config' plugin to the new CLI.
Date Tue, 11 Apr 2017 14:52:45 GMT

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/57952/
-----------------------------------------------------------

(Updated April 11, 2017, 2:52 p.m.)


Review request for mesos, Joseph Wu and Kevin Klues.


Changes
-------

Rebased.


Bugs: MESOS-7269
    https://issues.apache.org/jira/browse/MESOS-7269


Repository: mesos


Description
-------

Used to show the plugins available for the user.
A Table abstraction has been added to print the plugins.


Diffs (updated)
-----

  src/cli_new/bin/settings.py 2f6162edc1722054bc44ad25956e6fe666d36c7f 
  src/cli_new/lib/cli/plugins/config/__init__.py PRE-CREATION 
  src/cli_new/lib/cli/plugins/config/main.py PRE-CREATION 
  src/cli_new/lib/cli/util.py ace07fb64e130e2f02d4ab5607ee1a84161ef88b 


Diff: https://reviews.apache.org/r/57952/diff/4/

Changes: https://reviews.apache.org/r/57952/diff/3-4/


Testing
-------

Tested manually, PEP8 and Pylint used to make sure that the code style is correct.


Thanks,

Armand Grillet


Mime
  • Unnamed multipart/alternative (inline, None, 0 bytes)
View raw message