mesos-reviews mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From Jan Schlicht <...@mesosphere.io>
Subject Review Request 58348: Used 'ASSERT_THREADSAFE' in Mesos.
Date Tue, 11 Apr 2017 12:28:28 GMT

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/58348/
-----------------------------------------------------------

Review request for mesos, Neil Conway and Till Toenshoff.


Bugs: MESOS-7193
    https://issues.apache.org/jira/browse/MESOS-7193


Repository: mesos


Description
-------

Using 'GTEST_IS_THREADSAFE' in asserts to fail tests that need
thread-safety early is problematic, because it may be undefined.
Instead, a new assertion is introduced that evaluates
'GTEST_IS_THREADSAFE' and succeeds or fails accordingly.


Diffs
-----

  src/tests/environment.cpp e3cff1847c44bb06bbe898211bfca35cf851217a 


Diff: https://reviews.apache.org/r/58348/diff/1/


Testing
-------

mesos-tests (using automake and CMake with macOS, Linux and Windows)


Thanks,

Jan Schlicht


Mime
  • Unnamed multipart/alternative (inline, None, 0 bytes)
View raw message