mesos-reviews mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From Jan Schlicht <...@mesosphere.io>
Subject Review Request 58347: Added 'ASSERT_THREADSAFE' in libprocess.
Date Tue, 11 Apr 2017 12:27:28 GMT

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/58347/
-----------------------------------------------------------

Review request for mesos, Neil Conway and Till Toenshoff.


Bugs: MESOS-7193
    https://issues.apache.org/jira/browse/MESOS-7193


Repository: mesos


Description
-------

Using 'GTEST_IS_THREADSAFE' in asserts to fail tests that need
thread-safety early is problematic, because it may be undefined.
Instead, a new assertion is introduced that evaluates
'GTEST_IS_THREADSAFE' and succeeds or fails accordingly.


Diffs
-----

  3rdparty/libprocess/include/process/gtest.hpp 27077ac9047447fc4c52cc76ab26420e5bc79418 
  3rdparty/libprocess/src/tests/future_tests.cpp f21361ed1e354778bcd0357afb71300f05d3ecfd

  3rdparty/libprocess/src/tests/io_tests.cpp 302fadc2a1894d3fd7c4f4975af3f2cc6c3a22de 
  3rdparty/libprocess/src/tests/limiter_tests.cpp b80b1da214f97b50aa7b61b79bbf683fd01116aa

  3rdparty/libprocess/src/tests/metrics_tests.cpp d7fdb06060b273e16be27a263b5ee268842aa25c

  3rdparty/libprocess/src/tests/process_tests.cpp bf90c7e78fd50ad7e16cc0a69a248ba71e2a7115

  3rdparty/libprocess/src/tests/reap_tests.cpp 30518dee6c2fb904a607c7a457a5ec7366aab818 


Diff: https://reviews.apache.org/r/58347/diff/1/


Testing
-------

libprocess-tests (using automake and CMake with macOS, Linux, Windows)


Thanks,

Jan Schlicht


Mime
  • Unnamed multipart/alternative (inline, None, 0 bytes)
View raw message