mesos-reviews mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From Adam B <a...@mesosphere.io>
Subject Re: Review Request 58292: Removed unnecesary break statements in local approver.
Date Tue, 11 Apr 2017 00:58:55 GMT

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/58292/#review171511
-----------------------------------------------------------


Ship it!




Ship It!

- Adam B


On April 10, 2017, 3:09 a.m., Alexander Rojas wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/58292/
> -----------------------------------------------------------
> 
> (Updated April 10, 2017, 3:09 a.m.)
> 
> 
> Review request for mesos, Adam B, Benjamin Bannier, and Neil Conway.
> 
> 
> Repository: mesos
> 
> 
> Description
> -------
> 
> Removes `break` statements located in lines following a `return`
> statement since they are effectively unreachable code, don't improve
> readability nor make the code cleaner.
> 
> 
> Diffs
> -----
> 
>   src/authorizer/local/authorizer.cpp e241edf4afa48d35dbbbb94d72e8e8690f5bedfc 
> 
> 
> Diff: https://reviews.apache.org/r/58292/diff/1/
> 
> 
> Testing
> -------
> 
> make check
> 
> 
> Thanks,
> 
> Alexander Rojas
> 
>


Mime
  • Unnamed multipart/alternative (inline, None, 0 bytes)
View raw message