mesos-reviews mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From Jason Lai <ja...@jasonlai.net>
Subject Re: Review Request 58279: Lazily unmount persistent volumes in DockerContainerizer.
Date Mon, 10 Apr 2017 20:46:48 GMT

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/58279/#review171476
-----------------------------------------------------------


Ship it!




Ship It!


src/slave/containerizer/docker.cpp
Line 665 (original), 667 (patched)
<https://reviews.apache.org/r/58279/#comment244413>

    Nit ditto https://reviews.apache.org/r/58278/diff/1?file=1686582#file1686582line829. Not
in the scope of this diff though.


- Jason Lai


On April 7, 2017, 11:46 p.m., Jie Yu wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/58279/
> -----------------------------------------------------------
> 
> (Updated April 7, 2017, 11:46 p.m.)
> 
> 
> Review request for mesos, Gilbert Song, Jason Lai, and Zhitao Li.
> 
> 
> Bugs: MESOS-7366
>     https://issues.apache.org/jira/browse/MESOS-7366
> 
> 
> Repository: mesos
> 
> 
> Description
> -------
> 
> Use MNT_DETACH to unmount persistent volumes in DockerContainerizer to
> workaround an issue of incorrect handling of container destroy
> failures. Currently, if unmount fails there, the containerizer will
> still treat the container as terminated, and the agent will schedule
> the cleanup of the container's sandbox. Since the mount hasn't been
> removed in the sandbox (e.g., due to EBUSY), that'll result in data in
> the persistent volume being incorrectly deleted. Use MNT_DETACH so
> that the mount point in the sandbox will be removed immediately. See
> MESOS-7366 for more details.
> 
> 
> Diffs
> -----
> 
>   src/slave/containerizer/docker.cpp be1a298b12374bced44e2467cb7e90a1599abb8f 
> 
> 
> Diff: https://reviews.apache.org/r/58279/diff/1/
> 
> 
> Testing
> -------
> 
> sudo make check
> 
> 
> Thanks,
> 
> Jie Yu
> 
>


Mime
  • Unnamed multipart/alternative (inline, None, 0 bytes)
View raw message