mesos-reviews mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From Mesos Reviewbot <revi...@mesos.apache.org>
Subject Re: Review Request 58289: Avoided excessive copying in the default implementation of 'stringify'.
Date Mon, 10 Apr 2017 19:34:24 GMT

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/58289/#review171462
-----------------------------------------------------------



Patch looks great!

Reviews applied: [58288, 58289]

Passed command: export OS='ubuntu:14.04' BUILDTOOL='autotools' COMPILER='gcc' CONFIGURATION='--verbose'
ENVIRONMENT='GLOG_v=1 MESOS_VERBOSE=1'; ./support/docker-build.sh

- Mesos Reviewbot


On April 10, 2017, 6:15 p.m., Benjamin Bannier wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/58289/
> -----------------------------------------------------------
> 
> (Updated April 10, 2017, 6:15 p.m.)
> 
> 
> Review request for mesos and Neil Conway.
> 
> 
> Bugs: MESOS-6560
>     https://issues.apache.org/jira/browse/MESOS-6560
> 
> 
> Repository: mesos
> 
> 
> Description
> -------
> 
> The default implementation of 'stringify' was always making needless
> copies of its argument which can be expensive for larger types. This
> patch changes the default overload of 'stringify' to always take its
> argument by const reference.
> 
> This change requires changing 'stringify' for 'bool' arguments from a
> 'stringify' template specialization to an overload.
> 
> 
> Diffs
> -----
> 
>   3rdparty/stout/include/stout/stringify.hpp 698431583d2288d3c635211e651914316bfd3ee9

> 
> 
> Diff: https://reviews.apache.org/r/58289/diff/1/
> 
> 
> Testing
> -------
> 
> `make check` (Fedora 25)
> 
> 
> Thanks,
> 
> Benjamin Bannier
> 
>


Mime
  • Unnamed multipart/alternative (inline, None, 0 bytes)
View raw message