mesos-reviews mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From Benjamin Bannier <benjamin.bann...@mesosphere.io>
Subject Review Request 58289: Avoided excessive copying in the default implementation of 'stringify'.
Date Mon, 10 Apr 2017 18:12:26 GMT

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/58289/
-----------------------------------------------------------

Review request for mesos and Neil Conway.


Bugs: MESOS-6560
    https://issues.apache.org/jira/browse/MESOS-6560


Repository: mesos


Description
-------

The default implementation of 'stringify' was always making needless
copies of its argument which can be expensive for larger types. This
patch changes the default overload of 'stringify' to always takes its
argument by const reference.

This change requires changing 'stringify' for 'bool' arguments from a
'stringify' template specialization to an overload.


Diffs
-----

  3rdparty/stout/include/stout/stringify.hpp 698431583d2288d3c635211e651914316bfd3ee9 


Diff: https://reviews.apache.org/r/58289/diff/1/


Testing
-------

`make check` (Fedora 25)


Thanks,

Benjamin Bannier


Mime
  • Unnamed multipart/alternative (inline, None, 0 bytes)
View raw message