mesos-reviews mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From James Peach <jpe...@apache.org>
Subject Review Request 58303: Pass the slave pointer directly to Master::removeTask.
Date Mon, 10 Apr 2017 15:48:15 GMT

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/58303/
-----------------------------------------------------------

Review request for mesos and Mesos Reviewbot.


Bugs: MESOS-7372
    https://issues.apache.org/jira/browse/MESOS-7372


Repository: mesos


Description
-------

In all cases where we call Master::removeTask, we have the correct slave
pointer in hand. We can just pass it down, avoiding the need to look it
up again with the SlaveID.


Diffs
-----

  src/master/master.hpp d537933d0b467a6f9996951c601b31338bb9d034 
  src/master/master.cpp c1f3c4f3bbcbfb10ae8fc974bd4a16ec070a79fd 


Diff: https://reviews.apache.org/r/58303/diff/1/


Testing
-------

Make check (Fedora 25). Internal fuzzing.


Thanks,

James Peach


Mime
  • Unnamed multipart/alternative (inline, None, 0 bytes)
View raw message