mesos-reviews mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From Alexander Rojas <alexan...@mesosphere.io>
Subject Review Request 58292: Removed unnecesary break statements in local approver.
Date Mon, 10 Apr 2017 10:09:31 GMT

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/58292/
-----------------------------------------------------------

Review request for mesos, Adam B, Benjamin Bannier, and Neil Conway.


Repository: mesos


Description
-------

Removes `break` statements located in lines following a `return`
statement since they are effectively unreachable code, don't improve
readability nor make the code cleaner.


Diffs
-----

  src/authorizer/local/authorizer.cpp e241edf4afa48d35dbbbb94d72e8e8690f5bedfc 


Diff: https://reviews.apache.org/r/58292/diff/1/


Testing
-------

make check


Thanks,

Alexander Rojas


Mime
  • Unnamed multipart/alternative (inline, None, 0 bytes)
View raw message