mesos-reviews mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From Armand Grillet <agril...@mesosphere.io>
Subject Re: Review Request 57951: Moved new CLI settings into a user-defined TOML file.
Date Mon, 10 Apr 2017 06:33:04 GMT

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/57951/
-----------------------------------------------------------

(Updated April 10, 2017, 6:33 a.m.)


Review request for mesos and Joseph Wu.


Bugs: MESOS-7269
    https://issues.apache.org/jira/browse/MESOS-7269


Repository: mesos


Description (updated)
-------

These settings were previously in `settings.py`.
We now use a TOML file containing the configuration, this
format has been chosen because:
  * It supports comments.
  * It is well-specified.
  * It allows logical grouping.
  * It maps ubiquitous data types.
This environement variable `MESOS_CLI_PLUGINS` is not used
anymore as plugins can be added using the TOML file instead.


Diffs (updated)
-----

  src/cli_new/README.md 0e60515b71192ce1a544711948a5c17a6f9002af 
  src/cli_new/bin/settings.py 274f8c63b0c642637f17aa2e3c8c4a8a5a059e37 
  src/cli_new/pip-requirements.txt 9cc8d096ac353f4ed2d40000318f2d0e439a6edf 


Diff: https://reviews.apache.org/r/57951/diff/3/

Changes: https://reviews.apache.org/r/57951/diff/2-3/


Testing
-------

Tested manually, PEP8 and Pylint used to make sure that the code style is correct.


Thanks,

Armand Grillet


Mime
  • Unnamed multipart/alternative (inline, None, 0 bytes)
View raw message