mesos-reviews mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From Gilbert Song <songzihao1...@gmail.com>
Subject Re: Review Request 58280: Added a test to verify persistent volume mount points removal.
Date Sat, 08 Apr 2017 01:19:48 GMT

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/58280/#review171395
-----------------------------------------------------------


Ship it!




Ship It!

- Gilbert Song


On April 7, 2017, 5:27 p.m., Jie Yu wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/58280/
> -----------------------------------------------------------
> 
> (Updated April 7, 2017, 5:27 p.m.)
> 
> 
> Review request for mesos, Gilbert Song, Jason Lai, and Zhitao Li.
> 
> 
> Bugs: MESOS-7366
>     https://issues.apache.org/jira/browse/MESOS-7366
> 
> 
> Repository: mesos
> 
> 
> Description
> -------
> 
> This test is used to catch regression related to MESOS-7366.
> 
> 
> Diffs
> -----
> 
>   src/tests/containerizer/linux_filesystem_isolator_tests.cpp 5e489ef6a522000c55b0fb9a27bce2567f82bb73

> 
> 
> Diff: https://reviews.apache.org/r/58280/diff/1/
> 
> 
> Testing
> -------
> 
> sudo make check
> 
> Without the fix, this test failed:
> ```
> [==========] Running 1 test from 1 test case.
> [----------] Global test environment set-up.
> [----------] 1 test from LinuxFilesystemIsolatorTest
> [ RUN      ] LinuxFilesystemIsolatorTest.ROOT_PersistentVolumeMountPointCleanup
> /home/jie/workspace/mesos/src/tests/containerizer/linux_filesystem_isolator_tests.cpp:879:
Failure
> (wait).failure(): Failed to clean up an isolator when destroying container: Failed to
unmount volume '/tmp/LinuxFilesystemIsolatorTest_ROOT_PersistentVolumeMountPointCleanup_Tl5a9W/sandbox/volume':
Failed to unmount '/tmp/LinuxFilesystemIsolatorTest_ROOT_PersistentVolumeMountPointCleanup_Tl5a9W/sandbox/volume':
Device or resource busy
> [  FAILED  ] LinuxFilesystemIsolatorTest.ROOT_PersistentVolumeMountPointCleanup (113
ms)
> [----------] 1 test from LinuxFilesystemIsolatorTest (121 ms total)
> 
> [----------] Global test environment tear-down
> [==========] 1 test from 1 test case ran. (165 ms total)
> [  PASSED  ] 0 tests.
> [  FAILED  ] 1 test, listed below:
> [  FAILED  ] LinuxFilesystemIsolatorTest.ROOT_PersistentVolumeMountPointCleanup
> ```
> 
> 
> Thanks,
> 
> Jie Yu
> 
>


Mime
  • Unnamed multipart/alternative (inline, None, 0 bytes)
View raw message