mesos-reviews mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From Jie Yu <yujie....@gmail.com>
Subject Review Request 58278: Lazily unmount persistent volumes in MesosContainerizer.
Date Fri, 07 Apr 2017 23:45:49 GMT

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/58278/
-----------------------------------------------------------

Review request for mesos, Gilbert Song, Jason Lai, and Zhitao Li.


Bugs: MESOS-7366
    https://issues.apache.org/jira/browse/MESOS-7366


Repository: mesos


Description
-------

Use MNT_DETACH when unmounting persistent volumes in Linux filesystem
isolator to workaround an issue of incorrect handling of container
destroy failures. Currently, if isolator cleanup returns a failure,
the slave will treat the container as terminated, and will schedule
the cleanup of the container's sandbox. Since the mount hasn't been
removed in the sandbox (e.g., due to EBUSY), that'll result in data in
the persistent volume being incorrectly deleted. Use MNT_DETACH so
that the mount point in the sandbox will be removed immediately.  See
MESOS-7366 for more details.


Diffs
-----

  src/slave/containerizer/mesos/isolators/filesystem/linux.cpp ae0031d8d8d6dfe0334b605fbb85e83de88ab436



Diff: https://reviews.apache.org/r/58278/diff/1/


Testing
-------

sudo make check


Thanks,

Jie Yu


Mime
  • Unnamed multipart/alternative (inline, None, 0 bytes)
View raw message