mesos-reviews mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From haosdent huang <haosd...@apache.org>
Subject Re: Review Request 58200: Fix mesos runs with docker(pid namespace mismatch).
Date Fri, 07 Apr 2017 16:31:17 GMT

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/58200/#review171361
-----------------------------------------------------------




src/slave/containerizer/docker.cpp
Lines 361-364 (patched)
<https://reviews.apache.org/r/58200/#comment244256>

    I use
    
    ```
    +    Parameter* pidParameter = dockerInfo.add_parameters();
    +    pidParameter->set_key("pid");
    +    pidParameter->set_value("host");
    +
    +    Parameter* privilegedParameter = dockerInfo.add_parameters();
    +    privilegedParameter->set_key("privileged");
    +    privilegedParameter->set_value("true");
    +
    ```
    
    and work in my side. May you help to double check again?


- haosdent huang


On April 5, 2017, 11:35 p.m., Deshi Xiao wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/58200/
> -----------------------------------------------------------
> 
> (Updated April 5, 2017, 11:35 p.m.)
> 
> 
> Review request for mesos, Alexander Rukletsov and haosdent huang.
> 
> 
> Bugs: MESOS-7210
>     https://issues.apache.org/jira/browse/MESOS-7210
> 
> 
> Repository: mesos
> 
> 
> Description
> -------
> 
> Becuase MESOS HTTP checks doesn't work when mesos runs with
> --docker_mesos_image ( pid namespace mismatch ).So let docker
> executor run with container add host pid mapping(--pid=host)
> 
> 
> Diffs
> -----
> 
>   src/slave/containerizer/docker.cpp ad9ab847cb3093724ef374d036c896b4e7f18b5e 
> 
> 
> Diff: https://reviews.apache.org/r/58200/diff/1/
> 
> 
> Testing
> -------
> 
> first testing : https://gist.github.com/xiaods/c5a11e3ab51e89a9609edc2c477f7ea8
> 
> 
> Thanks,
> 
> Deshi Xiao
> 
>


Mime
  • Unnamed multipart/alternative (inline, None, 0 bytes)
View raw message