mesos-reviews mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From Vinod Kone <vinodk...@gmail.com>
Subject Re: Review Request 58196: Implemented TCP check support in command and default executors.
Date Fri, 07 Apr 2017 01:58:36 GMT

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/58196/#review171307
-----------------------------------------------------------




src/checks/checker.hpp
Lines 64 (patched)
<https://reviews.apache.org/r/58196/#comment244189>

    std::string&



src/checks/checker.hpp
Lines 91 (patched)
<https://reviews.apache.org/r/58196/#comment244190>

    std::string&



src/checks/checker.cpp
Lines 138 (patched)
<https://reviews.apache.org/r/58196/#comment244191>

    string&



src/checks/checker.cpp
Lines 210 (patched)
<https://reviews.apache.org/r/58196/#comment244192>

    s/a binary/the binary/



src/checks/checker.cpp
Lines 234 (patched)
<https://reviews.apache.org/r/58196/#comment244193>

    string&



src/checks/checker.cpp
Lines 263 (patched)
<https://reviews.apache.org/r/58196/#comment244194>

    string&



src/checks/checker.cpp
Lines 318 (patched)
<https://reviews.apache.org/r/58196/#comment244195>

    string&



src/checks/checker.cpp
Lines 1081 (patched)
<https://reviews.apache.org/r/58196/#comment244196>

    Does this work even when executor is running with its own file system?



src/checks/checker.cpp
Lines 1088 (patched)
<https://reviews.apache.org/r/58196/#comment244197>

    s/tcpCommand/command/



src/checks/checker.cpp
Lines 1090 (patched)
<https://reviews.apache.org/r/58196/#comment244198>

    s/tcpCommandArguments/argv/



src/checks/checker.cpp
Lines 1166-1169 (patched)
<https://reviews.apache.org/r/58196/#comment244200>

    It's a bit unfortunate that the `errno` returned by `connect` is subsumed by the tcp check
command. But I guess there is no easy way to expose that to the scheduler.



src/tests/check_tests.cpp
Lines 947 (patched)
<https://reviews.apache.org/r/58196/#comment244201>

    Same comment as previous review. This can result in flaky test.



src/tests/check_tests.cpp
Lines 959 (patched)
<https://reviews.apache.org/r/58196/#comment244202>

    `has_succeeded` sounds weird here :) more reason to change the field name.



src/tests/check_tests.cpp
Lines 1913 (patched)
<https://reviews.apache.org/r/58196/#comment244203>

    ditto.


- Vinod Kone


On April 4, 2017, 10:25 p.m., Alexander Rukletsov wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/58196/
> -----------------------------------------------------------
> 
> (Updated April 4, 2017, 10:25 p.m.)
> 
> 
> Review request for mesos, Gastón Kleiman and Vinod Kone.
> 
> 
> Bugs: MESOS-7275
>     https://issues.apache.org/jira/browse/MESOS-7275
> 
> 
> Repository: mesos
> 
> 
> Description
> -------
> 
> See summary.
> 
> 
> Diffs
> -----
> 
>   src/checks/checker.hpp fb939d85dbec2bf7e81e0c11518ccecddc5a7a11 
>   src/checks/checker.cpp 7510bf23977e007d101fab635865b7160c3a5af6 
>   src/launcher/default_executor.cpp 9cc40c6391a931f9cdf6965e64be231980537299 
>   src/launcher/executor.cpp bc69beb884d95d1616b2a3d928cdbf00f70f7c88 
>   src/tests/check_tests.cpp d7fcbf940102efe0841f07e8c4937a78361bc422 
> 
> 
> Diff: https://reviews.apache.org/r/58196/diff/1/
> 
> 
> Testing
> -------
> 
> make check on Mac OS 10.11.6 and various linux variants.
> 
> 
> Thanks,
> 
> Alexander Rukletsov
> 
>


Mime
  • Unnamed multipart/alternative (inline, None, 0 bytes)
View raw message