mesos-reviews mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From Anand Mazumdar <an...@apache.org>
Subject Re: Review Request 58245: Fixed compilation error on Linux with recent glibc.
Date Thu, 06 Apr 2017 23:04:58 GMT

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/58245/#review171266
-----------------------------------------------------------


Ship it!




Thanks for fixing it!

- Anand Mazumdar


On April 6, 2017, 8:25 p.m., Neil Conway wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/58245/
> -----------------------------------------------------------
> 
> (Updated April 6, 2017, 8:25 p.m.)
> 
> 
> Review request for mesos and Anand Mazumdar.
> 
> 
> Bugs: MESOS-7365
>     https://issues.apache.org/jira/browse/MESOS-7365
> 
> 
> Repository: mesos
> 
> 
> Description
> -------
> 
> Recent versions of glibc deprecate the implicit inclusion of
> <sys/sysmacros.h> via <sys/types.h>, so we should now include
> <sys/sysmacros.h> directly when necessary.
> 
> 
> Diffs
> -----
> 
>   src/linux/fs.cpp 16c4583cbf06db7dae393c1ca6221ae115296773 
>   src/slave/containerizer/mesos/isolators/gpu/isolator.cpp d4ab5393caa01d61397079201f32cfaf96d6a59a

>   src/tests/containerizer/fs_tests.cpp 098f12b9a7e1e8a36292bc7394b4d089a78ec2a1 
> 
> 
> Diff: https://reviews.apache.org/r/58245/diff/2/
> 
> 
> Testing
> -------
> 
> Mesos now compiles on recent Arch; it previously did not.
> 
> Tested on internal CI, doesn't break the build on other supported platforms.
> 
> 
> Thanks,
> 
> Neil Conway
> 
>


Mime
  • Unnamed multipart/alternative (inline, None, 0 bytes)
View raw message