mesos-reviews mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From James Peach <jpe...@apache.org>
Subject Review Request 58242: Improve master robustness against duplicate UPIDs.
Date Thu, 06 Apr 2017 18:32:29 GMT

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/58242/
-----------------------------------------------------------

Review request for mesos and Mesos Reviewbot.


Bugs: MESOS-7363
    https://issues.apache.org/jira/browse/MESOS-7363


Repository: mesos


Description
-------

It is possible for a malicious client to send
libprocess SUBSCRIBE requests that will trigger the
!frameworks.principals.contains(...) CHECK. This can happen
if the client sends a subscribe with a framework ID, then a
second subscribe with a different framework ID but the same
UPID. The invariant in the master is that a UPID uniquely
identifies a given framework. This is violated if we allow
multiple frameworks with the same UPID.


Diffs
-----

  src/linux/ldcache.cpp e93334465911d3ec37f38d51249486d5d317bdb3 
  src/master/master.cpp 6a6a570e52d21bfb2443f981e3d7faf8c36f74bc 


Diff: https://reviews.apache.org/r/58242/diff/1/


Testing
-------

make checl (Fedora 25). Internal fuzzer run.


Thanks,

James Peach


Mime
  • Unnamed multipart/alternative (inline, None, 0 bytes)
View raw message