mesos-reviews mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From Mesos Reviewbot <revi...@mesos.apache.org>
Subject Re: Review Request 58209: Fixed network isolator crash when network interface is not found.
Date Wed, 05 Apr 2017 17:40:43 GMT

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/58209/#review171151
-----------------------------------------------------------



Patch looks great!

Reviews applied: [58209]

Passed command: export OS='ubuntu:14.04' BUILDTOOL='autotools' COMPILER='gcc' CONFIGURATION='--verbose'
ENVIRONMENT='GLOG_v=1 MESOS_VERBOSE=1'; ./support/docker-build.sh

- Mesos Reviewbot


On April 5, 2017, 1:35 p.m., Dmitry Zhuk wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/58209/
> -----------------------------------------------------------
> 
> (Updated April 5, 2017, 1:35 p.m.)
> 
> 
> Review request for mesos, Chi Zhang and Jie Yu.
> 
> 
> Bugs: MESOS-7348
>     https://issues.apache.org/jira/browse/MESOS-7348
> 
> 
> Repository: mesos
> 
> 
> Description
> -------
> 
> It's not an error if network interface cannot be found, and None is returned by lookup
functions as a result in this case. This fix ensures that None is properly handled, when composing
an error messge in network isolator.
> 
> 
> Diffs
> -----
> 
>   src/slave/containerizer/mesos/isolators/network/port_mapping.cpp dfa71fb6fe867c2f34451ca9f3e7f7f62402133c

> 
> 
> Diff: https://reviews.apache.org/r/58209/diff/1/
> 
> 
> Testing
> -------
> 
> 
> Thanks,
> 
> Dmitry Zhuk
> 
>


Mime
  • Unnamed multipart/alternative (inline, None, 0 bytes)
View raw message