mesos-reviews mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From Jay Guo <guojiannan1...@gmail.com>
Subject Re: Review Request 58095: Refactored functions that render /roles and GetRoles endpoints.
Date Wed, 05 Apr 2017 02:24:02 GMT

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/58095/
-----------------------------------------------------------

(Updated April 5, 2017, 10:24 a.m.)


Review request for mesos, Adam B, Alexander Rojas, Benjamin Mahler, and Michael Park.


Changes
-------

add `MESOS-4732`. add mcypark as reviewer.


Bugs: MESOS-4732 and MESOS-7260
    https://issues.apache.org/jira/browse/MESOS-4732
    https://issues.apache.org/jira/browse/MESOS-7260


Repository: mesos


Description
-------

Instead of generating JSON object, `Master::Http::roles()` now
leverages `jsonify` to compute output. Also approver is taken
out from its continuation function. This is for easier and cleaner
implementation of framework authorization in /roles endpoint,
see MESOS-7260.


Diffs
-----

  src/master/http.cpp 6cf9d350446d1b2d4a6e67d552217daff32657ff 
  src/master/master.hpp 1b077424373d6e195e4ab29e150dedbc3f3f95ab 


Diff: https://reviews.apache.org/r/58095/diff/2/


Testing
-------

no functional changes
make check


Thanks,

Jay Guo


Mime
  • Unnamed multipart/alternative (inline, None, 0 bytes)
View raw message