mesos-reviews mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From Joseph Wu <jos...@mesosphere.io>
Subject Re: Review Request 58126: Windows: Stout: Reimplemented `stringify_args`.
Date Tue, 04 Apr 2017 00:32:53 GMT

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/58126/#review170947
-----------------------------------------------------------


Ship it!




I dislike the fact we need to do this sort of escaping, but the code LGTM.


3rdparty/stout/include/stout/os/windows/shell.hpp
Lines 185-186 (original), 185-213 (patched)
<https://reviews.apache.org/r/58126/#comment243788>

    So in English...
    
    1) Any argument with a space, tab, newline, vertical tab, or quote must be double-quoted
(").
    2) Backslashes at the very end of an argument must be escaped.
    3) Backslashes that precede a double-quote must be escaped.  The double-quote must also
be escaped.
    
    (Maybe add this as a comment.)



3rdparty/stout/include/stout/os/windows/shell.hpp
Lines 201 (patched)
<https://reviews.apache.org/r/58126/#comment243790>

    s/metait/metacharacter/ ?
    
    How did that typo come about :D ?



3rdparty/stout/include/stout/os/windows/shell.hpp
Lines 223 (patched)
<https://reviews.apache.org/r/58126/#comment243793>

    s/it/character/


- Joseph Wu


On March 31, 2017, 4:49 p.m., Andrew Schwartzmeyer wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/58126/
> -----------------------------------------------------------
> 
> (Updated March 31, 2017, 4:49 p.m.)
> 
> 
> Review request for mesos, Jeff Coffler, John Kordich, Joseph Wu, Li Li, and Michael Park.
> 
> 
> Bugs: MESOS-5418 and MESOS-5522
>     https://issues.apache.org/jira/browse/MESOS-5418
>     https://issues.apache.org/jira/browse/MESOS-5522
> 
> 
> Repository: mesos
> 
> 
> Description
> -------
> 
> This was an unused function that ended up being the correct place to
> implement proper `argv` concatenation and escaping.  It returns a
> `std::wstring` for use (speifically) by `::CreateProcessW`.  This brings
> us a bit closer to Unicode support within Mesos.
> 
> 
> Diffs
> -----
> 
>   3rdparty/stout/include/stout/os/windows/shell.hpp fdce93c2146ddec6117577b538dca77c416e0c01

> 
> 
> Diff: https://reviews.apache.org/r/58126/diff/1/
> 
> 
> Testing
> -------
> 
> Testing done later in chain.
> 
> 
> Thanks,
> 
> Andrew Schwartzmeyer
> 
>


Mime
  • Unnamed multipart/alternative (inline, None, 0 bytes)
View raw message