mesos-reviews mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From Joseph Wu <jos...@mesosphere.io>
Subject Re: Review Request 57974: Windows: Replaced WindowsLauncher with SubprocessLauncher.
Date Mon, 03 Apr 2017 23:42:50 GMT

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/57974/#review170929
-----------------------------------------------------------


Ship it!




LGTM.  I can fix the below before committing.


src/slave/containerizer/mesos/launcher.cpp
Line 183 (original), 188 (patched)
<https://reviews.apache.org/r/57974/#comment243775>

    Eh, this line goes over 80 characters... just needs a newline :)


- Joseph Wu


On March 27, 2017, 3:38 p.m., Andrew Schwartzmeyer wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/57974/
> -----------------------------------------------------------
> 
> (Updated March 27, 2017, 3:38 p.m.)
> 
> 
> Review request for mesos, John Kordich, Joseph Wu, Li Li, and Michael Park.
> 
> 
> Repository: mesos
> 
> 
> Description
> -------
> 
> This commit Rename `PosixLauncher` to `SubprocessLauncher`, and deletes
> the trivially derived class `WindowsLauncher`.  The same launcher is now
> suitable for both POSIX systems and Windows.  Thus, its previous name
> became a misnomer. As everything is controlled via `Subprocess`, it
> lends itself to a good new name.
> 
> 
> Diffs
> -----
> 
>   src/slave/containerizer/mesos/containerizer.cpp 527c96d7637be863e734102ca431e1488d6397e4

>   src/slave/containerizer/mesos/isolators/posix.hpp 627004663cbd7223a252b875c51454a20e645be6

>   src/slave/containerizer/mesos/launcher.hpp 79f6eea0ee8e564e90b36208672df150dbc5d540

>   src/slave/containerizer/mesos/launcher.cpp 5114c130efbfb252dde1e85c081f5174e66f57af

>   src/tests/container_logger_tests.cpp 4ccb2e4abf5623f5918526bf39ad99fb87869eaa 
>   src/tests/containerizer/mesos_containerizer_tests.cpp 9a5cfe49540fcb3364b4c57cb92fcd264e63cf36

> 
> 
> Diff: https://reviews.apache.org/r/57974/diff/2/
> 
> 
> Testing
> -------
> 
> Testing done at end of chain.
> 
> 
> Thanks,
> 
> Andrew Schwartzmeyer
> 
>


Mime
  • Unnamed multipart/alternative (inline, None, 0 bytes)
View raw message