mesos-reviews mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From Andrew Schwartzmeyer <and...@schwartzmeyer.com>
Subject Re: Review Request 58161: Fixed HealthyTaskNonShell test on Windows.
Date Mon, 03 Apr 2017 23:35:22 GMT

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/58161/
-----------------------------------------------------------

(Updated April 3, 2017, 11:35 p.m.)


Review request for mesos, Jeff Coffler, John Kordich, Joseph Wu, Li Li, and Michael Park.


Changes
-------

Add test results.


Repository: mesos


Description
-------

Instead of using `TRUE_COMMAND`, we needed to use `add_arguments` for
each argument to avoid smashing the set of arguments into one string.
That is, we cannot execute `"cmd /c exit 0"`, we have to execute `"cmd"`
with arguments `"cmd", "/c", "exit 0"`.


Diffs
-----

  src/tests/health_check_tests.cpp 211f8b8578e811d3f2a229387cc0ce8327ae8cb6 


Diff: https://reviews.apache.org/r/58161/diff/1/


Testing (updated)
-------

## make check

`make check` on CentOS passed (excepting `LdcacheTest.Parse` which also fails on `master`
so it's machine issue, not caused by these changes).

## mesos-tests

```
[----------] Global test environment tear-down
[==========] 559 tests from 58 test cases ran. (4051620 ms total)
[  PASSED  ] 556 tests.
[  FAILED  ] 3 tests, listed below:
[  FAILED  ] CommandExecutorCheckTest.CommandCheckTimeout
[  FAILED  ] CombinedAuthenticatorTest.MultipleAuthenticators
[  FAILED  ] CopyFetcherPluginTest.FetchExistingFile

...

[       OK ] CommandExecutorCheckTest.CommandCheckTimeout (15730 ms)
```

Re-ran `CommandCheckTimeout`, failure was a fluke. `MultipleAuthenticators` and `FetchExistingFile`
are known issues.

## libprocess-tests

```
[----------] Global test environment tear-down
[==========] 116 tests from 26 test cases ran. (11408 ms total)
[  PASSED  ] 116 tests.
```

## stout-tests

```
[----------] Global test environment tear-down
[==========] 230 tests from 39 test cases ran. (4712 ms total)
[  PASSED  ] 228 tests.
[  FAILED  ] 2 tests, listed below:
[  FAILED  ] Base64Test.EncodeURLSafe
[  FAILED  ] Base64Test.DecodeURLSafe
```

Known failure.


Thanks,

Andrew Schwartzmeyer


Mime
  • Unnamed multipart/alternative (inline, None, 0 bytes)
View raw message