mesos-reviews mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From Mesos Reviewbot <revi...@mesos.apache.org>
Subject Re: Review Request 58161: Fixed HealthyTaskNonShell test on Windows.
Date Mon, 03 Apr 2017 23:09:42 GMT

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/58161/#review170944
-----------------------------------------------------------



Patch looks great!

Reviews applied: [56364, 56367, 57973, 57974, 57975, 57976, 58125, 58126, 58127, 58128, 58160,
58161]

Passed command: export OS='ubuntu:14.04' BUILDTOOL='autotools' COMPILER='gcc' CONFIGURATION='--verbose'
ENVIRONMENT='GLOG_v=1 MESOS_VERBOSE=1'; ./support/docker-build.sh

- Mesos Reviewbot


On April 3, 2017, 9:21 p.m., Andrew Schwartzmeyer wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/58161/
> -----------------------------------------------------------
> 
> (Updated April 3, 2017, 9:21 p.m.)
> 
> 
> Review request for mesos, Jeff Coffler, John Kordich, Joseph Wu, Li Li, and Michael Park.
> 
> 
> Repository: mesos
> 
> 
> Description
> -------
> 
> Instead of using `TRUE_COMMAND`, we needed to use `add_arguments` for
> each argument to avoid smashing the set of arguments into one string.
> That is, we cannot execute `"cmd /c exit 0"`, we have to execute `"cmd"`
> with arguments `"cmd", "/c", "exit 0"`.
> 
> 
> Diffs
> -----
> 
>   src/tests/health_check_tests.cpp 211f8b8578e811d3f2a229387cc0ce8327ae8cb6 
> 
> 
> Diff: https://reviews.apache.org/r/58161/diff/1/
> 
> 
> Testing
> -------
> 
> (Pending results. Should all be fixed!)
> 
> 
> Thanks,
> 
> Andrew Schwartzmeyer
> 
>


Mime
  • Unnamed multipart/alternative (inline, None, 0 bytes)
View raw message