mesos-reviews mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From Benjamin Bannier <benjamin.bann...@mesosphere.io>
Subject Re: Review Request 58043: Cleaned up usage of namespace-qualified identifiers.
Date Mon, 03 Apr 2017 18:32:35 GMT

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/58043/#review170912
-----------------------------------------------------------


Ship it!




Let's get these in as they are strictly improvements.

To make such changes cheaper in the future I am strongly in favor of making a sweep across
the code base, and adding new style checkers. I believe if we'd relax the rule you applied
here of identifier used multiple times to also include cases where it is only used once one
would be able to automate this.

- Benjamin Bannier


On April 3, 2017, 7:26 p.m., Neil Conway wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/58043/
> -----------------------------------------------------------
> 
> (Updated April 3, 2017, 7:26 p.m.)
> 
> 
> Review request for mesos and Benjamin Bannier.
> 
> 
> Repository: mesos
> 
> 
> Description
> -------
> 
> Cleaned up usage of namespace-qualified identifiers.
> 
> 
> Diffs
> -----
> 
>   src/authentication/executor/jwt_secret_generator.cpp 5530a845aa629cd2e9b790d9c958442ff8e7ef89

>   src/master/allocator/mesos/hierarchical.cpp 8d54a8cca1bb478f4437f68c5e14f66a9f9bb9e9

>   src/master/master.cpp ab071f56a66ae66c97a185b2377a9cfe9a5c1ade 
>   src/slave/containerizer/composing.cpp b5b66b3218a20dcdc7c3174e5ac8fe970ee6462a 
>   src/slave/containerizer/mesos/isolators/cgroups/subsystems/cpu.cpp 39da15a512de9138aa01e319def906ad9348811d

>   src/slave/containerizer/mesos/linux_launcher.cpp 80c9ab2e297c88f1e75e6715b88ef9fa7e38b046

>   src/tests/default_executor_tests.cpp 6dadd8937eb6809bcb0aca55fab1cb7f17c3262f 
> 
> 
> Diff: https://reviews.apache.org/r/58043/diff/2/
> 
> 
> Testing
> -------
> 
> `make check`
> 
> 
> Thanks,
> 
> Neil Conway
> 
>


Mime
  • Unnamed multipart/alternative (inline, None, 0 bytes)
View raw message