mesos-reviews mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From Mesos Reviewbot <revi...@mesos.apache.org>
Subject Re: Review Request 58150: Removed an old comment from 'v1/mesos.proto'.
Date Mon, 03 Apr 2017 16:17:22 GMT

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/58150/#review170886
-----------------------------------------------------------



Patch looks great!

Reviews applied: [58150]

Passed command: export OS='ubuntu:14.04' BUILDTOOL='autotools' COMPILER='gcc' CONFIGURATION='--verbose'
ENVIRONMENT='GLOG_v=1 MESOS_VERBOSE=1'; ./support/docker-build.sh

- Mesos Reviewbot


On April 3, 2017, 3:05 p.m., Greg Mann wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/58150/
> -----------------------------------------------------------
> 
> (Updated April 3, 2017, 3:05 p.m.)
> 
> 
> Review request for mesos and Neil Conway.
> 
> 
> Repository: mesos
> 
> 
> Description
> -------
> 
> This patch removes an old comment in 'include/v1/mesos.proto'
> regarding the `DiskInfo.persistence.principal` field. Commit
> 73790d3c141f91cc3a8f546091ac62594995b788 removed this comment
> from 'include/mesos.proto', but neglected to update the v1
> proto definitions.
> 
> 
> Diffs
> -----
> 
>   include/mesos/v1/mesos.proto 82d020e05b303a8248a90bc482b76b54b335146c 
> 
> 
> Diff: https://reviews.apache.org/r/58150/diff/1/
> 
> 
> Testing
> -------
> 
> 
> Thanks,
> 
> Greg Mann
> 
>


Mime
  • Unnamed multipart/alternative (inline, None, 0 bytes)
View raw message