mesos-reviews mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From Benjamin Bannier <benjamin.bann...@mesosphere.io>
Subject Re: Review Request 58084: Adjust `using` style in a few places.
Date Mon, 03 Apr 2017 09:06:28 GMT

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/58084/#review170831
-----------------------------------------------------------



See my comment at https://reviews.apache.org/r/58043/.

- Benjamin Bannier


On March 30, 2017, 6:49 p.m., Neil Conway wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/58084/
> -----------------------------------------------------------
> 
> (Updated March 30, 2017, 6:49 p.m.)
> 
> 
> Review request for mesos and Benjamin Bannier.
> 
> 
> Repository: mesos
> 
> 
> Description
> -------
> 
> When an identifier is used many times in an implementation file, we
> typically add a `using` statement for that identifier.
> 
> 
> Diffs
> -----
> 
>   src/common/build.cpp a87d2cf5463b13d59cf548e7e0edfca600e256b1 
>   src/slave/container_loggers/lib_logrotate.cpp ae5d0acdaf64304675ee0f144c8d0c0988ba9112

>   src/tests/cluster.cpp 7f09a0c8b93e8fa945e7b2c809624b12e61b4198 
>   src/tests/containerizer/composing_containerizer_tests.cpp 934824c61a857bdc4d2d8ef790b64a33d14eab9f

> 
> 
> Diff: https://reviews.apache.org/r/58084/diff/1/
> 
> 
> Testing
> -------
> 
> `make check`
> 
> 
> Thanks,
> 
> Neil Conway
> 
>


Mime
  • Unnamed multipart/alternative (inline, None, 0 bytes)
View raw message